Add periodic refresh #1855
Merged
Add periodic refresh #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
⚠️ DO NOT MERGE
Guardiola31337
commented
Apr 1, 2019
| @@ -680,7 +680,8 @@ public NavigationRoute build() { | |||
| .voiceInstructions(true) | |||
| .bannerInstructions(true) | |||
| .roundaboutExits(true) | |||
| .eventListener(eventListener); | |||
| .eventListener(eventListener) | |||
| .enableRefresh(true); | |||
There was a problem hiding this comment.
Enabling refresh by default
danesfeder
reviewed
Apr 2, 2019
There was a problem hiding this comment.
@Guardiola31337 this is looking great, let's add the options you have marked in the TODOs and 🚢
Guardiola31337
force-pushed
the
pg-periodic-refresh
branch
from
4c5b556
to
b322c74
Compare
|
Remaining TODOs were addressed and this is updated and ready for a final round of 👀 |
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
============================================
+ Coverage 33.59% 33.83% +0.23%
- Complexity 1015 1026 +11
============================================
Files 254 256 +2
Lines 8701 8746 +45
Branches 660 662 +2
============================================
+ Hits 2923 2959 +36
- Misses 5518 5525 +7
- Partials 260 262 +2 |
Guardiola31337
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
…c and etas on a regular basis when in navigation
Guardiola31337
force-pushed
the
pg-periodic-refresh
branch
from
b322c74
to
c312f28
Compare
danesfeder
approved these changes
Apr 2, 2019
Guardiola31337
added a commit
that referenced
this pull request
Apr 2, 2019
…c and etas on a regular basis when in navigation (#1855)
Guardiola31337
added a commit
that referenced
this pull request
Apr 2, 2019
…c and etas on a regular basis when in navigation (#1855)
Guardiola31337
added a commit
that referenced
this pull request
Apr 12, 2019
…c and etas on a regular basis when in navigation (#1855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds periodic refresh functionality
What's the goal?
Add a polling mechanism to refresh traffic and ETAs on a regular basis (5 minutes) when in navigation
How is it being implemented?
RouteRefresherincludes acheckmethod which 👀 if the refresh interval has been met. This is checked withinRouteProcessorRunnableand iftrue,RouteRefresher#refreshis called which callsRouteRefresh#refreshand updates a flag to preventrefreshfrom being called multiple times until the route response is received. At this point, the refreshed route is passed in viamapboxNavigation.startNavigation(directionsRoute, DirectionsRouteType.FRESH_ROUTE);which updates traffic and ETAs data. Finally, everything is reset in preparation for the next interval check.TODOs
MapboxNavigationOptionsto enable / disable refresh route (enabled by default every 5 minutes) and remove hardcoded default intervalmapbox-navigation-android/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/MapboxNavigation.java
Line 935 in 4c5b556
MapboxNavigationOptionsto customize the refresh interval (defaulted to 5 minutes)How has this been tested?
Checklist
SNAPSHOTupstream dependencies if needed)